Add rosbag2-storage-mcap on linux-64 and win-64 #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because these some reason are getting built with missing headers. They also have nothing to do with the packages I want to build.
|
Can you by chance CI check? It seems that the action failed from a timeout. |
|
Can you merge now that it passes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added
pid-controllerandrosx-introspectionto ignored packages, because they for some reason get included in my vinca recipe and fail during build and have nothing to do withrosbag2-storage-mcap.The
pid-controllerfails when missing headercontrol_msgs/msg/multi_dof_command.hpp. The build environment has an old version ofcontrol_msgswhich does not include this message. I would happily help bumpingcontrol_msgs, but vinca seems pretty blind to me adding it to the dependencies; I don't know what is going on there.The
rosx-introspectionfails when missing headerrapidjson/document.h. I tried experimenting with adding it to various files like./env/robostackenv.yaml,./conda_build_config.yaml, and./.ci_support/conda_forge_pinnings.yamlto no avail, so I also gave up on understanding where I mess with vinca to include this library in the build.